-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove alloc::prelude #89898
Merged
Merged
Remove alloc::prelude #89898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the libs team decision in rust-lang#58935. Closes rust-lang#58935
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 14, 2021
antoyo
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bors r+ |
📌 Commit 8007dfa has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 15, 2021
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…htriplett Remove alloc::prelude As per the libs team decision in rust-lang#58935. Closes rust-lang#58935
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…htriplett Remove alloc::prelude As per the libs team decision in rust-lang#58935. Closes rust-lang#58935
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Oct 16, 2021
…htriplett Remove alloc::prelude As per the libs team decision in rust-lang#58935. Closes rust-lang#58935
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2021
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#89509 (Stabilize `unreachable_unchecked` as `const fn`) - rust-lang#89898 (Remove alloc::prelude) - rust-lang#89902 (Restrict the aarch64 outline atomics test to Linux) - rust-lang#89906 (Moved format-version constant to rustdoc-json-types) - rust-lang#89912 (emitter: current substitution can be multi-line) - rust-lang#89914 (Emit impl difference error for GenericBoundFailure too) - rust-lang#89915 (Some outlives cleanup) - rust-lang#89918 (Add some GATs related regression tests) - rust-lang#89921 ([fuchsia] Update process info struct) - rust-lang#89925 (updating docs to mention usage of AtomicBool) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
mkroening
added a commit
to mkroening/libhermit-rs
that referenced
this pull request
Oct 28, 2021
alloc::prelude has been removed in rust-lang/rust#89898, effective since nightly-2021-10-17.
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Oct 28, 2021
289: Remove uses of alloc::prelude r=mkroening a=mkroening alloc::prelude has been removed in rust-lang/rust#89898, effective since nightly-2021-10-17. bors r+ Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Oct 29, 2021
276: Remove Cargo.lock r=stlankes a=mkroening Since we use no `Cargo.lock` in downstream builds, we should not use one in upstream CI either. 289: Remove uses of alloc::prelude r=mkroening a=mkroening alloc::prelude has been removed in rust-lang/rust#89898, effective since nightly-2021-10-17. bors r+ Co-authored-by: Martin Kröning <mkroening@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the libs team decision in #58935.
Closes #58935